Fix absolute urls on 'managed user error' event#9550
Merged
Conversation
ahukkanen
requested changes
Jul 11, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Overall great, I've just noticed one potential issue and also left one suggestion regarding the string.
decidim-verifications/app/events/decidim/verifications/managed_user_error_event.rb
Outdated
Show resolved
Hide resolved
decidim-verifications/spec/events/decidim/verifications/managed_user_error_event_spec.rb
Show resolved
Hide resolved
Member
Author
|
This is ready to be reviewed again @ahukkanen |
ahukkanen
reviewed
Jul 15, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Thanks @andreslucena !
I noticed one more issue but as mentioned below, we can also handle that in another PR if you prefer to leave it outside of this PR (since it's not related to the issue this PR is fixing).
Just let me know which way you prefer!
decidim-verifications/app/events/decidim/verifications/managed_user_error_event.rb
Show resolved
Hide resolved
Contributor
|
Since you are unavailable now, I'll just go ahead and merge this as-is and leave the remaining issue unresolved. I will handle the remaining issue in another PR myself shortly. |
ahukkanen
approved these changes
Jul 20, 2022
This was referenced Jul 21, 2022
This was referenced Aug 15, 2022
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Remove unecessary requires for simple_event examples * Fix bug on factory where two users could be on different organizations * Fix absolute urls on 'managed user error' event * Using EngineRouter for generating the conflict_url * Changing the event to other participant * Wrap only the EngineRouter for URLs * Change 'other participant' string in email subject too * Update specs with latest changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Sometime ago, we detected that we were using relative URLs (aka paths) on some mailers (see #9146). I had one pending:
I found what was the missing piece, basically I had to explicitly pass the host on the URL method:
decidim/decidim-verifications/app/events/decidim/verifications/managed_user_error_event.rb
Line 30 in a07c713
I thought this was handled automatically 😄
In the process, I've removed some unnecessary requires that I found. That's already done here:
decidim/decidim-core/lib/decidim/core/test.rb
Line 28 in 5288afe
I've also fixed a bug on the factory where, on a verification conflict, a managed_user and a user could be from two different organizations. This doesn't make much sense.
📌 Related Issues
Testing