Fix / Expose createMapController properly to let overriding#9425
Merged
Fix / Expose createMapController properly to let overriding#9425
Conversation
ahukkanen
approved these changes
Jun 14, 2022
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
ahukkanen
pushed a commit
that referenced
this pull request
Jul 8, 2022
andreslucena
added a commit
that referenced
this pull request
Jul 13, 2022
Merged
12 tasks
12 tasks
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes how the maps controller is being exposed to let it being overriden to use a custom controller.
📌 Related Issues
window.Decidim.createMapControlleris not exposed anymore #9399Testing
In a new development app I've added the following snippet to
app/packs/decidim/decidim_application.js:📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
