Remove description from questions in elections#9401
Merged
andreslucena merged 7 commits intodevelopfrom Jun 16, 2022
Merged
Conversation
Contributor
Author
|
This should be ready for review @ahukkanen @andreslucena |
decidim-elections/app/commands/decidim/elections/admin/setup_election.rb
Show resolved
Hide resolved
ahukkanen
requested changes
Jun 14, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
LGTM overall.
@microstudi Is it on purpose you are still preserving the description field in the database? Maybe we should remove it from the DB as well if we want to get rid of that field. But maybe you have a valid reason to preserve it?
Another place where it is still preserved is the translations:
Contributor
Author
|
Thanks for your sharp eye @ahukkanen ! |
Contributor
Great thanks @microstudi ! But note that there was one spec that was calling the |
Contributor
Author
|
all green @ahukkanen ! |
12 tasks
andreslucena
pushed a commit
that referenced
this pull request
Jun 17, 2022
* remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec
andreslucena
pushed a commit
that referenced
this pull request
Jun 29, 2022
* remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
* remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
* remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec
ahukkanen
pushed a commit
that referenced
this pull request
Jul 8, 2022
…9522) * Remove description from questions in elections (#9401) * remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec * Fix Rails version on migration Co-authored-by: Ivan Vergés <ivan@platoniq.net>
andreslucena
added a commit
that referenced
this pull request
Jul 13, 2022
…9522) * Remove description from questions in elections (#9401) * remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec * Fix Rails version on migration Co-authored-by: Ivan Vergés <ivan@platoniq.net>
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* remove description * remove description from tests * send empty description to keep bulletin board happy * fix schema * fix question type spec * remove description from questions in the DB * remove failing spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Description is not used at all in elections UI.
This PR removes the description but still sends to the bulletin board and empty "subtitle" for the question just to keep compatibility. This should ease things up if one day description must be reinstated.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
