Skip to content

Add empty database (aka no seed) installation manual#9349

Merged
ahukkanen merged 8 commits intodecidim:developfrom
mainio:doc/add_no_seed_installation_manual
Jun 8, 2022
Merged

Add empty database (aka no seed) installation manual#9349
ahukkanen merged 8 commits intodecidim:developfrom
mainio:doc/add_no_seed_installation_manual

Conversation

@sinaeftekhar
Copy link
Copy Markdown
Contributor

@sinaeftekhar sinaeftekhar commented May 23, 2022

🎩 What? Why?

Documentation for installing decidim with no seeds is proposed here.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • :AVOID breaking the continuous integration build.
  • :AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@sinaeftekhar sinaeftekhar marked this pull request as ready for review May 23, 2022 08:06
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @sinaeftekhar!
I have some feedback, can you give it an eye please? Thanks

- The source file renamed to 'empty-database' as suggsted.
- Other parts of the documentation chaneged(whenever possible)
- Parts that was not addressed is already explained in a comment
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Few suggestions below.

- Edit heading
- Add new note section with brief explanation of organization meaning
-
- Add link to the system panel documentation
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more details, and we're good to go!

@andreslucena andreslucena changed the title Add no seed installation manual Add empty database (aka no seed) installation manual May 27, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @sinaeftekhar

@andreslucena andreslucena requested a review from ahukkanen June 7, 2022 08:30
@ahukkanen ahukkanen merged commit b6a08de into decidim:develop Jun 8, 2022
@ahukkanen ahukkanen deleted the doc/add_no_seed_installation_manual branch June 8, 2022 08:27
andreslucena pushed a commit that referenced this pull request Jul 6, 2022
* Add 'No-seed Installation' page & add links from manual installation

* Add documentation for no-seed installation

* Address reviews' comments

- The source file renamed to 'empty-database' as suggsted.
- Other parts of the documentation chaneged(whenever possible)
- Parts that was not addressed is already explained in a comment

* Edit reviewers' comments

- Edit heading
- Add new note section with brief explanation of organization meaning
-

* Edit comments on documentation

- Add link to the system panel documentation

* Edit last set of reviewers' comments
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* Add 'No-seed Installation' page & add links from manual installation

* Add documentation for no-seed installation

* Address reviews' comments

- The source file renamed to 'empty-database' as suggsted.
- Other parts of the documentation chaneged(whenever possible)
- Parts that was not addressed is already explained in a comment

* Edit reviewers' comments

- Edit heading
- Add new note section with brief explanation of organization meaning
-

* Edit comments on documentation

- Add link to the system panel documentation

* Edit last set of reviewers' comments
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants