Don't show deleted resources in last activities #9293
Merged
Conversation
ahukkanen
approved these changes
May 13, 2022
andreslucena
added a commit
that referenced
this pull request
May 18, 2022
* Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses
ahukkanen
pushed a commit
that referenced
this pull request
May 24, 2022
…9330) * Don't show deleted resources in last activities (#9293) * Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses * Fix markup in spec so it's compatible with v0.26
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When someone makes a comment and deletes it, it's still accessible on the Last Activity content block of the homepage. This PR fixes that.
📌 Related Issues
Testing
📷 Screenshots
(This currently in Metadecidim homepage)