Fix local storage protocol options for uploaders#9285
Merged
andreslucena merged 6 commits intodecidim:developfrom May 16, 2022
Merged
Fix local storage protocol options for uploaders#9285andreslucena merged 6 commits intodecidim:developfrom
andreslucena merged 6 commits intodecidim:developfrom
Conversation
andreslucena
approved these changes
May 16, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just checked it locally, everything works well. Thanks for the PR 👍🏽
Member
|
There are a couple failings in CI, but they're already fixed in |
andreslucena
pushed a commit
that referenced
this pull request
May 18, 2022
* Fix local protocol options for the application uploader * Add specs to test the storage protocol options for the uploaders * Fix issues with the spec ports related to uploaders * Avoid messing with the secrets hash * Fix generator specs after application uploader refactoring
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* Fix local protocol options for the application uploader * Add specs to test the storage protocol options for the uploaders * Fix issues with the spec ports related to uploaders * Avoid messing with the secrets hash * Fix generator specs after application uploader refactoring
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* Fix local protocol options for the application uploader * Add specs to test the storage protocol options for the uploaders * Fix issues with the spec ports related to uploaders * Avoid messing with the secrets hash * Fix generator specs after application uploader refactoring
This was referenced Jul 26, 2022
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Fix local protocol options for the application uploader * Add specs to test the storage protocol options for the uploaders * Fix issues with the spec ports related to uploaders * Avoid messing with the secrets hash * Fix generator specs after application uploader refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The newsletter images are not displayed correctly in the development environment.
I believe this also applies to all URLs fetched from the application uploaders, i.e. the uploaded attachments.
📌 Related Issues
Testing
See #9154.
📋 Checklist
docs/.