Fix hashtag parsing on URLs with fragments#9221
Merged
Conversation
lahdeero
approved these changes
May 5, 2022
Contributor
lahdeero
left a comment
There was a problem hiding this comment.
Tested locally and works great!
ahukkanen
approved these changes
May 13, 2022
andreslucena
added a commit
that referenced
this pull request
May 18, 2022
* Fix hashtag parsing on URLs with fragments * Fix spec
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Fix hashtag parsing on URLs with fragments * Fix spec
ahukkanen
pushed a commit
that referenced
this pull request
May 19, 2022
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Fix hashtag parsing on URLs with fragments * Fix spec
Merged
12 tasks
12 tasks
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Fix hashtag parsing on URLs with fragments * Fix spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When there's a proposal with a body with a URL with a fragment, the Hashtag parser thinks that this is hashtag and links it like that (/search?term=%23fragment). This PR fixes that.
📌 Related Issues
Testing
Create a proposal with a URL like http://www.example.org/path/#fragment
(Mind that for trying this out locally you should stop the rails' server, edit the proposal and modify the body).
📷 Screenshots
Before
After