Configure online meetings embedded services with ENV vars#9219
Merged
Configure online meetings embedded services with ENV vars#9219
Conversation
agustibr
reviewed
May 3, 2022
Contributor
agustibr
left a comment
There was a problem hiding this comment.
Great @microstudi 😍
Thanks!
Member
|
I didn't have the chance to try this out yet, but it looks really nice 😄 Just a thing, there's now a help text that need to take into account this: I think two solutions for this:
Any of those would be good for me, so choose whatever you prefer. |
Contributor
Author
|
I think we can use only the domains. This way we can fill the allowed services automatically from the configuration. |
andreslucena
approved these changes
May 4, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just tried it out locally and it works great. I've also read the code and it LGTM. Thanks for the PR, I think it's really useful!
ahukkanen
approved these changes
May 13, 2022
12 tasks
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* add configuration var for embedabble services in meetings * add ENV var for embeddable meetings * fix separator * dynamic allowed services in help
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* add configuration var for embedabble services in meetings * add ENV var for embeddable meetings * fix separator * dynamic allowed services in help
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* add configuration var for embedabble services in meetings * add ENV var for embeddable meetings * fix separator * dynamic allowed services in help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Since the introduccion of the online meetings it is possible to embed an iframe with a link for an external video service (Jit.si, etc). However the list of allowed services was hardcoded to only
www.youtube.com www.twitch.tv meet.jit.si.This adds a configurable accessor into the Meetings module and a generic ENV var (
MEETING_EMBEDDABLE_SERVICES) to allow system maintainers to configure this.Note that a nice follow up for this could be to allow system admins to configure this in /system.
Testing
Use the ENV var
MEETING_EMBEDDABLE_SERVICESto add alternatives to the default allowed services.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
