Fix dynamic validation and title change for titled attachments#9175
Merged
ahukkanen merged 10 commits intodecidim:developfrom May 3, 2022
Merged
Fix dynamic validation and title change for titled attachments#9175ahukkanen merged 10 commits intodecidim:developfrom
ahukkanen merged 10 commits intodecidim:developfrom
Conversation
added 6 commits
April 20, 2022 19:55
ahukkanen
requested changes
Apr 30, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Looks good and tested this works great!
Just one refactoring idea below.
ahukkanen
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After #8681 it seemed that user could change title of an attachment, but it didn't really do much. Here we fix so user can change initial attachment title and can also change it later when editing resource.
Guidance changes:
Also fixed dynamic validation for titled attachments.
📌 Related Issues
Testing
See #8998
📷 Screenshots