Add favicon pwa uploader and icons in manifest#8645
Merged
andreslucena merged 9 commits intodevelopfrom Jan 24, 2022
Merged
Conversation
9eac5e3 to
aaa1745
Compare
14 tasks
6 tasks
ferblape
previously approved these changes
Dec 27, 2021
andreslucena
requested changes
Jan 17, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just a couple changes/suggestions, can you give it a look 🙏🏽 ?
a68801a to
2676ebf
Compare
2676ebf to
74604e6
Compare
Member
|
Also, the failing spec "[CI] Core (lib specs) / Tests (pull_request)" is related and needs to be fixed @quinHD |
andreslucena
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR changes the way we upload the favicon and how it is resized. This is to improve the appearance for the PWA
📌 Related Issues
Link your PR to an issue
#8478
📷 Screenshots
Please add screenshots of the changes you're proposing
♥️ Thank you!