Skip to content

Fix elections with ruby 3#9133

Merged
andreslucena merged 9 commits intodecidim:developfrom
mainio:fix/elections-ruby-3
Apr 12, 2022
Merged

Fix elections with ruby 3#9133
andreslucena merged 9 commits intodecidim:developfrom
mainio:fix/elections-ruby-3

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Apr 4, 2022 •
edited
Loading

🎩 What? Why?

This updates:

📌 Related Issues

Testing

See that CI is green.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Apr 4, 2022

@ahukkanen let me know when this is ready to be merged, so I can merge it in ruby3 upgrade branch.

@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Apr 4, 2022

@alecslupu I'm waiting for @andreslucena to merge decidim/decidim-bulletin-board#251 first since I don't want to merge my own PRs... 😄

Not long anymore, the PR is ready but we just need that merged first to release new versions of the libraries and bulletin board Docker container.

@ahukkanen
Revert the process type filter to "tally" during "tally_started"
370873f 
This is because the bulletin board / its clients and voting
schemes internally use message keys such as "tally.nnn". We need
to query the messages with the same keys.
@ahukkanen ahukkanen mentioned this pull request Apr 6, 2022
Merged
@ahukkanen ahukkanen marked this pull request as ready for review April 6, 2022 07:30
@ahukkanen ahukkanen requested a review from andreslucena April 6, 2022 07:30
@ahukkanen ahukkanen mentioned this pull request Apr 6, 2022
Merged
12 tasks
andreslucena
andreslucena reviewed Apr 6, 2022
View reviewed changes
@ahukkanen ahukkanen requested a review from andreslucena April 7, 2022 15:09
andreslucena
andreslucena approved these changes Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if it's ready to be merged

@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Apr 12, 2022

LGTM, let me know if it's ready to be merged

Yes ready! Feel free to merge.

@andreslucena andreslucena merged commit fc6e578 into decidim:develop Apr 12, 2022
@ahukkanen ahukkanen deleted the fix/elections-ruby-3 branch April 12, 2022 14:56
@andreslucena andreslucena added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: elections type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Apr 13, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: elections type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahukkanen @alecslupu @andreslucena