Conversation
It was converted using decaffeinate: ```bash npm install -g decaffeinate decaffeinate social-share-button.coffee ```
Can't find variable: SocialShareButton console error)
ahukkanen
requested changes
Mar 18, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Just a couple of code styling preferences?
decidim-core/app/packs/src/decidim/vendor/social-share-button.js
Outdated
Show resolved
Hide resolved
decidim-core/app/packs/src/decidim/vendor/social-share-button.js
Outdated
Show resolved
Hide resolved
Contributor
|
Tested this and it fixes the problem and works fine. I added a couple of code review comments above. |
andreslucena
added a commit
that referenced
this pull request
Mar 22, 2022
…ton` console error) (#9041) * Add social-share-button.js in vendor/ dir It was converted using decaffeinate: ```bash npm install -g decaffeinate decaffeinate social-share-button.coffee ``` * Add Copyright notice of the original author * Fix linter offenses * Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After the update to Webpacker, we've lost the social-share-button provided functionality: the icons are visible but when you click on them, it doesn't do anything, just a console error that the Object is undefined.
This PR fixes that by copying the JavaScript that we need for this.
As this file was originally CoffeeScript, I needed to transform it first. It was converted using decaffeinate:
Related to this issue, I'm working on implementing this feature ourselves, so we don't depend on any external dependency. Personally, I think that this current solution is a bit ugly at the moment: we have the JS and CSS locally but depend on the gem's Ruby code for the helper.
📌 Related Issues
Testing