Bulk actions for budgeting projects in admin panel by lahdeero · Pull Request #8986 · decidim/decidim

lahdeero · 2022-03-08T12:34:09Z

🎩 What? Why?

Add admin group actions to budget projects. This is similar functionality to what we have with proposals.

There is also small changes to proposal bulk actions:

Fix callout notification translations
Use shared callout notification
Minor refactoring

📌 Related Issues

https://meta.decidim.org/processes/roadmap/f/122/proposals/16954

Testing

Sign in as admin
Go to Processes -> choose a process -> Components -> Budgets -> Manage projects
Select projects
Change category / scope / selected for implementation in actions dropdown.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

♥️ Thank you!

andreslucena

LGTM. I tried it in the staging server and could do all the different actions. Couldn't find any bug.

Regarding the code, I see that it was copied from the current implementation for proposals (i.e. https://github.com/decidim/decidim/blob/develop/decidim-proposals/app/packs/src/decidim/proposals/admin/proposals.js is mostly the same as decidim-budgets/app/packs/src/decidim/budgets/admin/projects.js - even with a typo in a comment 😄 (// Expose functions to make them **avaialble** in .js.erb templates). I think its the way to go as it'll enable us to refactor it and remove duplication when the time arrives.

The other changes are great: moving a proposal helper method from decidim-admin to decidim-proposals, cleaning up the projects table, moving the js_callout partial to a shared directory, etc.

decidim-budgets/app/views/decidim/budgets/admin/projects/_bulk-actions.html.erb

…-actions.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

lahdeero · 2022-04-04T13:49:11Z

Regarding the code, I see that it was copied from the current implementation for proposals

Yeah 😁. Now that I looked it again it may need some cleaning because I'm not sure if projects have answers... I can take closer look tomorrow

andreslucena · 2022-04-05T07:49:34Z

I'm not sure if projects have answers

I haven't catch that, but no, projects don't have answers (at least for now, maybe it could make sense in the future, but as far as I know it isn't planned).

andreslucena · 2022-04-05T07:49:50Z

Uops sorry, wrongly closed.

…/decidim into feature/bulk_actions_for_projects

lahdeero · 2022-04-05T08:44:44Z

@andreslucena I did notice that there was code like this in projects.js

selectedProjectsNotPublishedAnswerCount

Did some cleaning in ec84d29 and updated QA

andreslucena

👍🏽 LGTM, thanks for the PR! I think it's really useful, specially for marking the projects as selected once the voting phase has finished.

ahukkanen

I found few places that could use some refactoring.

I would aim not to duplicate code and instead find ways to create APIs which allow us to use the same code in multiple places.

Even after these changes I'm not expecting it to be a perfect "bulk actions API" but just to aim to reduce the amount of duplicate code.

decidim-budgets/app/views/decidim/budgets/admin/projects/update_category.js.erb

decidim-budgets/app/packs/src/decidim/budgets/admin/projects.js

decidim-proposals/app/views/decidim/proposals/admin/proposals/update_category.js.erb

* Initial * Can change projects scope * Can select and unselect projects * Move js-callout partial to admin shared * Some refactoring and add tests * Fix i18n path and js linter errors * Dont hide import proposals to projects button * Dont change closing character * Enable permissions * Fix proposal callout translations * Allow boolean args and add comments * Update decidim-budgets/app/views/decidim/budgets/admin/projects/_bulk-actions.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Show selected count and clean copy paste code * Fix typo * Combine js.erb views * Refactor projects to use bulk actions api * Proposals admin uses bulk actions api * Update bulk actions for proposals * Fix tests * Combine proposal update category and update scope * Fix tests again * Update merge proposal selectors and tests * Give up with bulk actions api Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Eero Lahdenperä added 11 commits March 3, 2022 19:17

Initial

69b70f4

Can change projects scope

8032949

Can select and unselect projects

e59d1d8

Move js-callout partial to admin shared

6023949

Some refactoring and add tests

3f64070

Fix i18n path and js linter errors

84cce56

Dont hide import proposals to projects button

24ba0a7

Dont change closing character

be954cb

Enable permissions

06a8b94

Fix proposal callout translations

b596248

Allow boolean args and add comments

831a39c

andreslucena added module: budgets type: feature labels Mar 28, 2022

andreslucena changed the title ~~Group actions for budgeting projects admin~~ Bulk actions for budgeting projects in admin panel Apr 4, 2022

andreslucena previously approved these changes Apr 4, 2022

View reviewed changes

decidim-budgets/app/views/decidim/budgets/admin/projects/_bulk-actions.html.erb Outdated Show resolved Hide resolved

lahdeero dismissed andreslucena’s stale review via bccc6e3 April 4, 2022 13:38

Update decidim-budgets/app/views/decidim/budgets/admin/projects/_bulk…

bccc6e3

…-actions.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

andreslucena closed this Apr 5, 2022

andreslucena reopened this Apr 5, 2022

Eero Lahdenperä added 3 commits April 5, 2022 11:21

Show selected count and clean copy paste code

ec84d29

Merge branch 'feature/bulk_actions_for_projects' of github.com:mainio…

20ff772

…/decidim into feature/bulk_actions_for_projects

Fix typo

85af6ba

andreslucena previously approved these changes Apr 22, 2022

View reviewed changes

ahukkanen requested changes Apr 29, 2022

View reviewed changes

ahukkanen mentioned this pull request Apr 29, 2022

Cannot select one of the top categories in bulk actions category selector #9206

Closed

Merge branch 'develop' into feature/bulk_actions_for_projects

1866b0c

Eero Lahdenperä added 3 commits May 3, 2022 17:38

Combine js.erb views

65012e2

Refactor projects to use bulk actions api

e72ee13

Proposals admin uses bulk actions api

806390a

lahdeero dismissed andreslucena’s stale review via 806390a May 3, 2022 16:02

Eero Lahdenperä added 6 commits May 4, 2022 13:17

Update bulk actions for proposals

7c45b53

Fix tests

dad58e3

Combine proposal update category and update scope

c354e7a

Fix tests again

422da43

Update merge proposal selectors and tests

64ee037

Give up with bulk actions api

250cbf4

ahukkanen approved these changes May 13, 2022

View reviewed changes

ahukkanen merged commit 7c023cd into decidim:develop May 13, 2022

ahukkanen deleted the feature/bulk_actions_for_projects branch May 13, 2022 15:37

ahukkanen mentioned this pull request May 13, 2022

Fix Rubocop violations and normalize locales #9305

Merged

12 tasks

andreslucena mentioned this pull request May 16, 2022

Fix 'Duplicate branch' lint offense in budgets #9306

Closed

sinaeftekhar mentioned this pull request Aug 8, 2022

Weird notification when using the bulk actions for proposals #9299

Closed

alecslupu added this to the 0.27.0 milestone Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bulk actions for budgeting projects in admin panel#8986

Bulk actions for budgeting projects in admin panel#8986
ahukkanen merged 25 commits intodecidim:developfrom
mainio:feature/bulk_actions_for_projects

lahdeero commented Mar 8, 2022 •

edited

Loading

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

lahdeero commented Apr 4, 2022

Uh oh!

andreslucena commented Apr 5, 2022 •

edited

Loading

Uh oh!

andreslucena commented Apr 5, 2022

Uh oh!

lahdeero commented Apr 5, 2022 •

edited

Loading

Uh oh!

andreslucena left a comment

Uh oh!

ahukkanen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

lahdeero commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📋 Checklist

📷 Screenshots

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lahdeero commented Apr 4, 2022

Uh oh!

andreslucena commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreslucena commented Apr 5, 2022

Uh oh!

lahdeero commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lahdeero commented Mar 8, 2022 •

edited

Loading

andreslucena commented Apr 5, 2022 •

edited

Loading

lahdeero commented Apr 5, 2022 •

edited

Loading