Skip to content

Fix accessibility issue related to the documents collection toggle#8907

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/document-collection-toggle-accessibility
Feb 24, 2022
Merged

Fix accessibility issue related to the documents collection toggle#8907
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/document-collection-toggle-accessibility

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 23, 2022

🎩 What? Why?

The document collection toggle has an accessibility violation because you cannot set an aria-expanded attribute to a <span> element. The allowed roles can be seen e.g. at:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded

Also, the elements that behave in a specific way should have consistent identificators as described in the related accessibility links.

WCAG 2.2 / 3.2.4 Consistent Identification (Level AA)

https://www.w3.org/TR/WCAG22/#consistent-identification
https://www.w3.org/WAI/WCAG22/Understanding/consistent-identification.html

Testing

Take a look at the accessibility tool at the participatory process index page with the default seeds.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Accessibility issue related to the document collection toggle

@andreslucena andreslucena added module: core team: accessibility type: fix PRs that implement a fix for a bug labels Feb 24, 2022
@andreslucena andreslucena merged commit 5bfb8bb into decidim:develop Feb 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/document-collection-toggle-accessibility branch February 24, 2022 08:11
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants