Fix accessibility issue related to the documents collection toggle#8907
Merged
andreslucena merged 1 commit intodecidim:developfrom Feb 24, 2022
Merged
Conversation
andreslucena
approved these changes
Feb 24, 2022
Member
|
Can you please backport to v0.26-stable 🙏🏽? Thanks |
Contributor
Author
|
Backport at #8950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The document collection toggle has an accessibility violation because you cannot set an
aria-expandedattribute to a<span>element. The allowed roles can be seen e.g. at:https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded
Also, the elements that behave in a specific way should have consistent identificators as described in the related accessibility links.
WCAG 2.2 / 3.2.4 Consistent Identification (Level AA)
https://www.w3.org/TR/WCAG22/#consistent-identification
https://www.w3.org/WAI/WCAG22/Understanding/consistent-identification.html
Testing
Take a look at the accessibility tool at the participatory process index page with the default seeds.
📋 Checklist
docs/.📷 Screenshots