Skip to content

Fix the illogical heading orders with the budget component views#8904

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/budgets-heading-order
Feb 24, 2022
Merged

Fix the illogical heading orders with the budget component views#8904
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/budgets-heading-order

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 23, 2022

🎩 What? Why?

This fixes some illogical heading orders with the budgets component.

As a sidenote, I think the budget component's index view that lists the budgets should have a <h2> level heading before the budgets listing. Now it only has a <h2> at the "my budgets" section which is confusing as the rest of the budgets does not have any heading. The screen reader user may think that all of the budgets are "my budgets" because they are under the same <h2> level heading. But this is another discussion as it is a change in functionality.

WCAG 2.2 / 1.3.1 Info and Relationships (Level A)

https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html

Testing

Check the heading orders in the budgets list view.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@andreslucena
Copy link
Copy Markdown
Member

As a sidenote, I think the budget component's index view that lists the budgets should have a <h2> level heading before the budgets listing. Now it only has a <h2> at the "my budgets" section which is confusing as the rest of the budgets does not have any heading. The screen reader user may think that all of the budgets are "my budgets" because they are under the same <h2> level heading. But this is another discussion as it is a change in functionality.

I see what you mean.

@carolromero It's about this page:

image

As an example, it could be for instance "Other budgets":

image

@andreslucena andreslucena merged commit 858f1dd into decidim:develop Feb 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/budgets-heading-order branch February 24, 2022 08:12
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: budgets team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants