Fix the illogical heading orders with the budget component views#8904
Merged
andreslucena merged 1 commit intodecidim:developfrom Feb 24, 2022
Merged
Fix the illogical heading orders with the budget component views#8904andreslucena merged 1 commit intodecidim:developfrom
andreslucena merged 1 commit intodecidim:developfrom
Conversation
Member
I see what you mean. @carolromero It's about this page: As an example, it could be for instance "Other budgets": |
andreslucena
approved these changes
Feb 24, 2022
Member
|
Can you please backport to v0.26-stable 🙏🏽? Thanks |
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
12 tasks
Contributor
Author
|
Backport at #8950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🎩 What? Why?
This fixes some illogical heading orders with the budgets component.
As a sidenote, I think the budget component's index view that lists the budgets should have a
<h2>level heading before the budgets listing. Now it only has a<h2>at the "my budgets" section which is confusing as the rest of the budgets does not have any heading. The screen reader user may think that all of the budgets are "my budgets" because they are under the same<h2>level heading. But this is another discussion as it is a change in functionality.WCAG 2.2 / 1.3.1 Info and Relationships (Level A)
https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html
Testing
Check the heading orders in the budgets list view.
📋 Checklist
docs/.