Skip to content

Make the button link font weight consistent with normal links#8891

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/consistent-button-link-weight
Feb 24, 2022
Merged

Make the button link font weight consistent with normal links#8891
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/consistent-button-link-weight

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 22, 2022

🎩 What? Why?

When implementing the fix at #8890, I noticed that when applying the .link class to a button, it has a different font-weight than a normal link.

This adds a new SCSS configuration variable for the link font-weight and applies this to both normal links as well as elements with the .link class.

📌 Related Issues

Testing

Create a link and a button with the .link class on the same page and see a difference in their font weights.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Before

Elements with the link class have different font weight than normal links

After

Elements with the link class have consistent font weight with the links

@andreslucena andreslucena added module: core team: accessibility type: fix PRs that implement a fix for a bug labels Feb 24, 2022
@andreslucena andreslucena merged commit 543cbd5 into decidim:develop Feb 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/consistent-button-link-weight branch February 24, 2022 08:27
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants