Add the "choose language" string in all locales to the language chooser#8883
Merged
andreslucena merged 1 commit intodecidim:developfrom Feb 23, 2022
Merged
Conversation
andreslucena
approved these changes
Feb 23, 2022
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
12 tasks
Contributor
Author
|
Backport at #8950. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Users using Decidim in other languages than the language initially provided for them cannot understand the "choose language" text, so it should be shown in all locales available for the users.
This also moves the "lang" attribute in the language controls to the link instead of the
<li>element which is apparently more correct (according to the original issue report).There is an related issue with the dropdown control which is that the contents of the control are automatically added to the
aria-labelattribute which is incorrect. I will look into this as a separate issue, it may also come from Foundation.WCAG 2.2 / 3.1.2 Language of Parts (Level AA)
https://www.w3.org/TR/WCAG22/#language-of-parts
https://www.w3.org/WAI/WCAG22/Understanding/language-of-parts.html
Testing
Ask a person speaking only another language to choose the language on a Decidim page.
📋 Checklist
docs/.