Skip to content

Add the "choose language" string in all locales to the language chooser#8883

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/language-chooser-labels
Feb 23, 2022
Merged

Add the "choose language" string in all locales to the language chooser#8883
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/language-chooser-labels

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 22, 2022

🎩 What? Why?

Users using Decidim in other languages than the language initially provided for them cannot understand the "choose language" text, so it should be shown in all locales available for the users.

This also moves the "lang" attribute in the language controls to the link instead of the <li> element which is apparently more correct (according to the original issue report).

There is an related issue with the dropdown control which is that the contents of the control are automatically added to the aria-label attribute which is incorrect. I will look into this as a separate issue, it may also come from Foundation.

WCAG 2.2 / 3.1.2 Language of Parts (Level AA)

https://www.w3.org/TR/WCAG22/#language-of-parts
https://www.w3.org/WAI/WCAG22/Understanding/language-of-parts.html

Testing

Ask a person speaking only another language to choose the language on a Decidim page.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@andreslucena andreslucena changed the title Add the choose language in all locales to the language chooser Add the "choose language" string in all locales to the language chooser Feb 23, 2022
@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug team: accessibility labels Feb 23, 2022
@andreslucena andreslucena merged commit 937fdba into decidim:develop Feb 23, 2022
@ahukkanen ahukkanen deleted the fix/language-chooser-labels branch February 23, 2022 14:56
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants