Skip to content

Improve logo link aria label#8878

Merged
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/logo-link-label
Feb 23, 2022
Merged

Improve logo link aria label#8878
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/logo-link-label

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 22, 2022

🎩 What? Why?

The logo link label is named illogically for screen reader users.

The link label should indicate for the screen reader what happens when the user clicks the link.

WCAG 2.2 / 2.4.6 Headings and Labels (Level AA)

https://www.w3.org/TR/WCAG22/#headings-and-labels
https://www.w3.org/WAI/WCAG22/Understanding/headings-and-labels.html

Testing

Ask a screen reader user to test the logo link.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Comment thread decidim-core/app/views/layouts/decidim/_logo.html.erb Outdated
@andreslucena andreslucena added module: core team: accessibility type: fix PRs that implement a fix for a bug labels Feb 22, 2022
@andreslucena andreslucena merged commit d4bee7a into decidim:develop Feb 23, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/logo-link-label branch February 23, 2022 14:57
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants