Skip to content

Add .keep file to empty directory to include on git committing#8786

Merged
andreslucena merged 1 commit intodevelopfrom
fix/add_keep-file-to-add-images-folder
Feb 7, 2022
Merged

Add .keep file to empty directory to include on git committing#8786
andreslucena merged 1 commit intodevelopfrom
fix/add_keep-file-to-add-images-folder

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

@ferblape ferblape commented Feb 5, 2022

🎩 What? Why?

After creating a new Decidim application and committing it I realised that the folder app/packs/images is not included (unless you have included an image) because is empty, and the Javascript of Decidim relies in the existence of that folder to compile

Adding a .keep file ensures the directory is committed to git

📌 Related Issues

Testing

  1. Create a new decidim app
  2. Add to a new git repo and commit
  3. The folder should be in the repo

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@andreslucena andreslucena added module: generators type: fix PRs that implement a fix for a bug labels Feb 7, 2022
@andreslucena andreslucena merged commit 94ea361 into develop Feb 7, 2022
@andreslucena andreslucena deleted the fix/add_keep-file-to-add-images-folder branch February 7, 2022 08:19
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ferblape
Copy link
Copy Markdown
Contributor Author

ferblape commented Feb 7, 2022

Yes! #8788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: generators type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants