Skip to content

Add "nofollow noopener" rel to the profile personal URL#8779

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/personal-url-rel
Feb 3, 2022
Merged

Add "nofollow noopener" rel to the profile personal URL#8779
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/personal-url-rel

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 3, 2022

🎩 What? Why?

There are many so called "profile spammers" on all Decidim instances. They create a profile, fill in the personal URL and about section and then they don't do anything on the website.

They do this to get link juice from the external site towards their site.

Here's some examples from MetaDecidim:

Let's stop giving them "link juice" for their unethical SEO practices.

📌 Related Issues

Testing

  • Go to the profile page
  • Inspect the personal URL link in the sidebar to see it has the rel="nofollow noopener" attribute
  • Smile as you just prevented these SEO experts from one of their tricks

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@alecslupu
Copy link
Copy Markdown
Contributor

Flacky test on initiatives.

@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug labels Feb 3, 2022
@andreslucena
Copy link
Copy Markdown
Member

I'd said this is a bug fix because we should have done this from ages for sure 😓

@andreslucena andreslucena merged commit 0f57973 into decidim:develop Feb 3, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please do the backport to v0.26 release branch 🙏🏽 ? Thanks

@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport is available at #8780.

@PierreMesure
Copy link
Copy Markdown
Contributor

Hi @ahukkanen, is there any reason why we're not adding "noreferrer" to the mix? I'm guessing it would prevent these websites' from identifying which targets bring them the most traffic?

@ahukkanen
Copy link
Copy Markdown
Contributor Author

@PierreMesure I don't have anything against adding noreferrer too. Feel free to add it.

eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Feb 21, 2022
@PierreMesure PierreMesure mentioned this pull request Mar 18, 2022
12 tasks
@PierreMesure
Copy link
Copy Markdown
Contributor

@ahukkanen, Finally did it and added ugc as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants