Allow assembly admins administer children assemblies#8773
Allow assembly admins administer children assemblies#8773andreslucena merged 5 commits intodecidim:developfrom
Conversation
e12acf2 to
f1393c3
Compare
tramuntanal
left a comment
There was a problem hiding this comment.
LGTM @LauraJaimeC I just have one question regarding the tests
|
First, thanks for this contribution. We've just talked a bit in @decidim/product meeting today, and we thought that this would be a great improvement for the current permissions in assemblies and it's relatives. By any chance, do you have a Metadecidim proposal to know more details about this? For what I've seen, given that there's a set of Grandmother > Mother > Child assembly, if you give an Admin user role to a participant in the Mother assembly, then... How it works before this PR
How it works after this PR
How I expected that this work
|
andreslucena
left a comment
There was a problem hiding this comment.
I've left a comment on how this should work, can you give it a look @LauraJaimeC @tramuntanal 🙏🏽 ? Thanks
|
First of all, thank you for this thorough testing @andreslucena We'll create the proposal in meta-decidim asap and will extend this PR with the missing permissions for Export and Duplicate. |
|
There's a failing relevant spec related to assemblies permissions, can you check it @LauraJaimeC 🙏🏽 ? |
Hi! can you review it again? Thanks! |
andreslucena
left a comment
There was a problem hiding this comment.
Now it works as expected, awesome!! I have some suggestions to improve this.
|
Also can you add more details with the last changes and how it should work in the PR description? Thanks |
|
@LauraJaimeC , we must backport to 0.25 also. |
|
Metadecidim proposal: https://meta.decidim.org/processes/roadmap/f/122/proposals/16942 |
We're in the process of releasing v0.26, so we don't accept backports to v0.25 already. For now, we have the v0.26.0.rc2, but we hope to have the v0.26.0 this week. Also, as this is a new feature, we don't accept backports for this. Of course, if you need it in v0.25 you could make a fork, backport the feature in your fork and configure your installation against that. |
…ecidim#8773)"" This reverts commit fb0ba39.
…ecidim#8773)"" This reverts commit fb0ba39.

🎩 What? Why?
An assembly admin can now create and list the child assemblies of which they are an admin.
In this hierarchy: Grandmother Assembly > Mother Assembly > Child Assembly, if assembly admin administrates the Mother Assembly, the user can:
Testing
📷 Screenshots