Make the webpacker gem a core dependency#8181
Merged
leio10 merged 6 commits intodecidim:developfrom Jul 2, 2021
Merged
Conversation
leio10
suggested changes
Jul 2, 2021
Contributor
leio10
left a comment
There was a problem hiding this comment.
Good job! I like how this process is getting better and better! 😍
leio10
approved these changes
Jul 2, 2021
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Decidim won't run without the
webpackergem anymore.Shouldn't it be a core dependency then rather than requiring everyone to add it manually as a dependency?
I also updated the app migration guide with some relevant parts as I went through it after #8180.
📌 Related Issues
Testing
📋 Checklist
docs/.