Skip to content

Make the webpacker gem a core dependency#8181

Merged
leio10 merged 6 commits intodecidim:developfrom
mainio:refactor/webpacker-dependency
Jul 2, 2021
Merged

Make the webpacker gem a core dependency#8181
leio10 merged 6 commits intodecidim:developfrom
mainio:refactor/webpacker-dependency

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Jul 1, 2021

🎩 What? Why?

Decidim won't run without the webpacker gem anymore.

Shouldn't it be a core dependency then rather than requiring everyone to add it manually as a dependency?

I also updated the app migration guide with some relevant parts as I went through it after #8180.

📌 Related Issues

Testing

  • Re-create the development app
  • See that webpacker is working

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I like how this process is getting better and better! 😍

@leio10 leio10 merged commit cb5c44d into decidim:develop Jul 2, 2021
@ahukkanen ahukkanen deleted the refactor/webpacker-dependency branch July 2, 2021 08:45
@ahukkanen ahukkanen mentioned this pull request Aug 31, 2021
12 tasks
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed type: enhancement target: developer-experience labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants