Docs: Update the module webpacker migration guide#8180
Merged
leio10 merged 2 commits intodecidim:developfrom Jul 1, 2021
Merged
Docs: Update the module webpacker migration guide#8180leio10 merged 2 commits intodecidim:developfrom
leio10 merged 2 commits intodecidim:developfrom
Conversation
12 tasks
leio10
approved these changes
Jul 1, 2021
| ---- | ||
| Decidim.register_component(:your_component) do |component| | ||
| component.engine = Decidim::YourComponent::Engine | ||
| component.stylesheet = "decidim/your_component/your_component" |
Contributor
There was a problem hiding this comment.
I've found that several components are still assigning the stylesheet attribute. I understand that this is not needed anymore, nor the admin_stylesheet attribute, right?
I'm thinking of creating a PR removing those attributes and all the assignments in the component manifests.
Contributor
Author
There was a problem hiding this comment.
Yes, those attributes no longer have any effect.
If you are planning to remove these attributes from the Decidim::ComponentManifest class, I suggest you also create replacement methods for stylesheet=(_ss) and admin_stylesheet=(_ss) that would throw more explanatory errors for the user guiding them to the migration guide.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This updates the Webpacker migration guide for Decidim modules regarding the new conventions available in the module's assets configuration file (
config/assets.rb).📌 Related Issues
Testing
Read the docs and see if you understand.
📋 Checklist
docs/.