Conversation
34fa41d to
31588f9
Compare
31588f9 to
aa1cd97
Compare
fe1951d to
48b1564
Compare
beagleknight
reviewed
Apr 2, 2021
Contributor
beagleknight
left a comment
There was a problem hiding this comment.
Amazing work @leio10 ! I just left some comments 😄
| valid_token? | ||
| end | ||
|
|
||
| def allow_unregistered? |
Contributor
There was a problem hiding this comment.
Is this supposed to be hardcoded or are we gonna create a setting for this?
Contributor
Author
There was a problem hiding this comment.
this is hardcoded to allow unregistered voters to fill the survey
decidim-elections/app/controllers/decidim/elections/votes_controller.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/services/decidim/elections/current_user_vote_flow.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/services/decidim/elections/current_user_vote_flow.rb
Outdated
Show resolved
Hide resolved
12 tasks
fca5942 to
e07726e
Compare
db64b70 to
69123bc
Compare
fddd415 to
384e232
Compare
b0f90b5 to
e4f625f
Compare
Base automatically changed from
feature/check_census_data
to
feat/generate_access_codes
April 5, 2021 15:58
6ad549d to
2c94f56
Compare
7a0e752 to
85cc8cd
Compare
The base branch was changed.
04137a3 to
31fff16
Compare
mrcasals
approved these changes
Apr 13, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: Let admins disable participatory space filters (#7819) Identify online voters (#7777) Restore vote tests in the elections module using the real bulletin board (#7802) Show initiative image in homepage (#7824) Let admins filter participatory space private users (#7817) Add Ballot Style to Census Datum (#7788) Show missing election component callout also for in-person votings (#7809) Fix canceling scope select doesnt open reveal (#7805) Fix: Reported users are displayed in all tenants (#7628) Evote - onboarding workflow (#7758) Add copy to clipboard feature to share links (#7697)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR allows voter to be identified using census data. This should be possible without being logged, so it has several implications:
To implement this feature, this PR defines a
VoteFlowclass to isolate the common behaviors for the two options, andCurrentUserVoteFlowandCensusLoginFlowto implement the different parts.After login the user (with the census data or the current user), the system generates a temporary
voter_tokento allow the user to vote in the next X minutes (a configurable value, 120 by default). It also generates a deterministicvoter_idthat will not change for the same election and voter. These values are included in the voting booth to be sent together with the encrypted vote to server to cast the vote.This means that there wont be a session with that token, so in the case of the census login, the voter will need to enter their credentials every time they want to access to the voting booth. On the other side, this increases the security of the system and it's usability when used by several voters.
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
Grabacion.de.pantalla.2021-03-31.a.las.11.39.30.mov