Skip to content

Bump mimemagic to 0.3.6#7701

Merged
mrcasals merged 1 commit intodevelopfrom
chore/update-mimemagic
Mar 24, 2021
Merged

Bump mimemagic to 0.3.6#7701
mrcasals merged 1 commit intodevelopfrom
chore/update-mimemagic

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

🎩 What? Why?

mimemagic 0.3.5 and all previous versions have been yanked. Only 0.3.6 and 0.4.0 are available. The reason seems to be this: mimemagicrb/mimemagic#97 This makes our tests fail.

This PR updates the dependency so tests can pass again.

📌 Related Issues

None

Testing

Ensure CI is green.

@mrcasals mrcasals merged commit 05afece into develop Mar 24, 2021
@mrcasals mrcasals deleted the chore/update-mimemagic branch March 24, 2021 13:47
@mrcasals
Copy link
Copy Markdown
Contributor Author

I'm fast-tracking this.

mrcasals added a commit that referenced this pull request Mar 24, 2021
@mrcasals mrcasals mentioned this pull request Mar 24, 2021
@pboling
Copy link
Copy Markdown

pboling commented Mar 24, 2021

@mrcasals - IANAL - but wanted to make you aware of the licensing discussion going on around this: https://gitlab.freedesktop.org/xdg/shared-mime-info/-/merge_requests/119#note_852741

@mrcasals
Copy link
Copy Markdown
Contributor Author

@pboling thanks for mentioning this! Apparently, both licenses are compatible 😄

mrcasals added a commit that referenced this pull request Mar 25, 2021
mrcasals added a commit that referenced this pull request Mar 25, 2021
entantoencuanto added a commit that referenced this pull request Mar 26, 2021
* develop: (64 commits)
  Fix report mailers when author is a meeting (#7683)
  New Crowdin updates (#7729)
  Fix form builder assuming proposals module availability (#7689)
  Fix a series of issues with proposal attachments in the public area (#7699)
  New Crowdin updates (#7711)
  Add accessibility labels to the <nav> menus (#7709)
  Fix heading order on the home page (#7710)
  Fix dropdown menu accessibility audits (#7708)
  Fix the aria attribute names (no aria prefix) (#7707)
  Fix validations for registration related fields in Conference form (#7675)
  New Crowdin updates (#7613)
  Use comments counter cache instead of additional query (#7627)
  Upgrade to decidim-bulletin_board 0.15.2 (#7659)
  Bump mimemagic to 0.3.6 (#7701)
  Ensure pagination elements per page is a valid option (#7680)
  Fix link to "Getting started guide" in README.adoc (#7695)
  Fix link to CONTRIBUTING.adoc in PR template (#7696)
  Fix the screen reader class name for comments opinion toggle (#7698)
  Fix initiative-m card hashtags (#7679)
  Don't run all jobs on every PR (#7693)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants