Skip to content

Add the votings content block in Homepage#7194

Merged
mrcasals merged 60 commits intodevelopfrom
feat/voting-content-block
Jan 28, 2021
Merged

Add the votings content block in Homepage#7194
mrcasals merged 60 commits intodevelopfrom
feat/voting-content-block

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Jan 21, 2021

🎩 What? Why?

Makes a voting promotable and adds the 'Highlighted votings' content block in the homepage.

In the specific:

  • An admin can:
    • Mark a Voting as promoted when creating or updating one;
    • See what Votings are highlighted via a golden star in the admin panel votings list;
    • Activate/deactivate the 'Highlighted votings' content block for the public home page;
    • Decide how many highlighted votings to show in the public home page (4, 8 or 12).
  • A normal user can:
    • See the votings by priority in the public homepage when the content block is activated.
    • See promoted votings in the highlight section of the votings page

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

highlight

♥️ Thank you!

leio10
leio10 previously approved these changes Jan 22, 2021
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🏎️ 👍

slickepinne
slickepinne previously approved these changes Jan 25, 2021
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

Base automatically changed from feat/manage-votings to develop January 25, 2021 13:29
@mrcasals mrcasals dismissed stale reviews from slickepinne and leio10 January 25, 2021 13:29

The base branch was changed.

@orlera orlera force-pushed the feat/voting-content-block branch from e60b769 to 279bd0f Compare January 26, 2021 16:16
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 😎

@orlera orlera marked this pull request as ready for review January 27, 2021 09:02
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 27, 2021

@decidim/mantainers approved by product, can be reviewed 🚀

Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcasals
Copy link
Copy Markdown
Contributor

Nice job!

@mrcasals mrcasals merged commit d6618d2 into develop Jan 28, 2021
@mrcasals mrcasals deleted the feat/voting-content-block branch January 28, 2021 13:55
andreslucena pushed a commit that referenced this pull request Feb 3, 2021
Co-authored-by: Agustí B.R <hola@agusti.cat>
@mrcasals mrcasals changed the title Manage the votings content block in Homepage Add the votings content block in Homepage Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage the votings content block in Homepage

6 participants