Merged
Conversation
2b90ee0 to
8ae129e
Compare
mrcasals
approved these changes
Feb 10, 2021
12 tasks
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Feb 10, 2021
This reverts commit 4976597.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When editing an initiative from the public side, if there was any validation error and the initiative had attachments an error was raised.
This is because the form is submitting the data as an array of strings with the IDs of the attachments, like
["553", "532"]. When the view tried to render this it crashed becase"532"is a String instead of aDecidim::Attachment📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots