Skip to content

Embedded jitsi meetings#7017

Closed
verarojman wants to merge 67 commits intodecidim:developfrom
Platoniq:feature/15596-embed-jitsi-meeting
Closed

Embedded jitsi meetings#7017
verarojman wants to merge 67 commits intodecidim:developfrom
Platoniq:feature/15596-embed-jitsi-meeting

Conversation

@verarojman
Copy link
Copy Markdown
Contributor

@verarojman verarojman commented Dec 14, 2020

🎩 What? Why?

This new feature lets Jitsi Meet rooms to be automatically generated and embedded in the meeting page when an online meeting is created by an admin.

The Jitsi server and the Jisi API used for this feature can be configured in secrets.yml and in the decidim.rb initializer.

It also adds a system to log users attendance to the videoconference, and view it from the admin for meetings component

📌 Related Issues

Testing

  • Create a meeting and check the "Embedded videoconference" option
  • Visit the meeting within its start_time and end_time
  • Click on the "Join videoconference" button
  • Leave the videoconference
  • Go to the admin panel to manage the meetings component and click on the "pulse" icon
  • View the attendance logs for the videoconference

📋 Checklist

  • ✔️ DO check open PR's to avoid duplicates.

  • ✔️ DO keep pull requests small so they can be easily reviewed.

  • ✔️ DO build locally before pushing.

  • ✔️ DO add seeds.

  • ✔️ DO make sure tests pass.

  • ✔️ DO make sure any new changes are documented in docs/.

  • ✔️ DO add link to MetaDecidim if it's a new feature.

  • AVOID breaking the continuous integration build.

  • AVOID making significant changes to the overall architecture.

  • Add more system specs

  • Add button for easy videoconference fullscreen

  • Add example values for JITSI_DOMAIN and JITSI_API_URL

📷 Screenshots

User

Join videoconference

Videoconference

Videoconference

Admin

Admin - Edit meeting

Admin - See Attendance Logs

Improve seeded meetings avoiding duplicated names

Admin - Seeds

♥️ Thank you!

@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@decidim decidim deleted a comment from qlty-cloud-legacy bot Dec 14, 2020
@verarojman verarojman marked this pull request as ready for review December 18, 2020 15:29
verarojman added a commit to Platoniq/decidim that referenced this pull request Dec 21, 2020
verarojman added a commit to Platoniq/decidim that referenced this pull request Dec 21, 2020
domain: <%= ENV["JITSI_DOMAIN"] %>
api_url: <%= ENV["JITSI_API_URL"] %>
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add here some examples? I'd write here the official URLs of jitsi, https:///meet.jit.si and ? (I don't actually know the API url 😅)

@andreslucena
Copy link
Copy Markdown
Member

Hi guys. Awesome to have this PR!! 😍

It looks much more advance to what I had initially in mind (having only an iframe) but at the same time using the Jitsi Javascript API allows us to have more control on most things.

We had it also planed for a contract that's starting next week, do you have a deadline for finishing with this PR?

@microstudi
Copy link
Copy Markdown
Contributor

@andreslucena probably we will finish by the end of the month.
Regarding to the contract, you can still improve it by generalizing a little bit more in terms of conference embedable providers (jtisim BB, youtube for streaming, etc)

videoconferences:
jitsi:
domain: <%= ENV["JITSI_DOMAIN"] %> # e.g. meet.jit.si
api_url: <%= ENV["JITSI_API_URL"] %> # e.g. https://meet.jit.si/external_api.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave trailing whitespace

@andreslucena andreslucena mentioned this pull request Mar 25, 2021
3 tasks
@stale
Copy link
Copy Markdown

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @andreslucena feel free to chime in.

@stale stale bot added the wontfix label Jun 26, 2021
@andreslucena
Copy link
Copy Markdown
Member

Finally, with the Online Meetings project, we've rethought what would be the better way of implementing these kinds of integrations and we want to explore the iframe way of tackling this. We also don't want to have more integrations/configurations regarding these kinds of services, at least by default in decidim. If you want so we could discuss having all of this integration through external modules and that decidim-meetings provides a contract so you can implement this (something like what was done with the Geocoding/Maps integration) or something like that. Thanks for your effort and time!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants