Skip to content

Fix erblint in CI in 0.22-stable#6938

Merged
tramuntanal merged 1 commit intodecidim:release/0.22-stablefrom
coopdevs:fix-erblint-in-ci
Nov 26, 2020
Merged

Fix erblint in CI in 0.22-stable#6938
tramuntanal merged 1 commit intodecidim:release/0.22-stablefrom
coopdevs:fix-erblint-in-ci

Conversation

@sauloperez
Copy link
Copy Markdown
Contributor

@sauloperez sauloperez commented Nov 26, 2020

🎩 What? Why?

We suddenly started getting errors like the following in release/0.22-stable and release/0.23-stable.

Run ./.github/run_erblint.sh
bundler: failed to load command: erblint (/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.5.0/bin/erblint)
NameError: uninitialized constant BetterHtml::Parser::HtmlError
Did you mean?  HtmlTokenizer

Apparently, the only way to solve it is upgrading to erblint 0.0.35. That, however, requires a Rubocop upgrade that is too costly. This will do the trick since this branch is only meant to receive fixes.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

We suddenly started getting errors like the following in `release/0.22-stable` and
`release/0.23-stable`.

```
Run ./.github/run_erblint.sh
bundler: failed to load command: erblint (/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.5.0/bin/erblint)
NameError: uninitialized constant BetterHtml::Parser::HtmlError
Did you mean?  HtmlTokenizer
```

Apparently the only way to solve it is upgrading to erblint 0.0.35. That
however, requires a Rubocop upgrade that is too costly.  This will do
the trick since this branch is only meant to receive fixes.
@sauloperez sauloperez changed the title Do not lint ERB in CI Do not lint ERB in CI in 0.22-stable Nov 26, 2020
@sauloperez sauloperez changed the title Do not lint ERB in CI in 0.22-stable Fix erblint in CI in 0.22-stable Nov 26, 2020
@tramuntanal tramuntanal merged commit c6d40d6 into decidim:release/0.22-stable Nov 26, 2020
@sauloperez sauloperez deleted the fix-erblint-in-ci branch November 27, 2020 07:50
sauloperez added a commit to CoopCat-Confederacio-de-Cooperatives/decidim-coopcat that referenced this pull request Nov 30, 2020
Now we can point back to upstream because
decidim/decidim#6938,
decidim/decidim#6905 and
decidim/decidim#6893 have been merged. There
were also other bug fixes in between.
microstudi pushed a commit to Platoniq/decidim that referenced this pull request Dec 16, 2020
We suddenly started getting errors like the following in `release/0.22-stable` and
`release/0.23-stable`.

```
Run ./.github/run_erblint.sh
bundler: failed to load command: erblint (/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.5.0/bin/erblint)
NameError: uninitialized constant BetterHtml::Parser::HtmlError
Did you mean?  HtmlTokenizer
```

Apparently the only way to solve it is upgrading to erblint 0.0.35. That
however, requires a Rubocop upgrade that is too costly.  This will do
the trick since this branch is only meant to receive fixes.
davidbeig pushed a commit to CoopCat-Confederacio-de-Cooperatives/decidim-coopcat that referenced this pull request Dec 2, 2025
Now we can point back to upstream because
decidim/decidim#6938,
decidim/decidim#6905 and
decidim/decidim#6893 have been merged. There
were also other bug fixes in between.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants