Skip to content

Fix erblint in Lint Code CI job#6913

Closed
sauloperez wants to merge 1 commit intodecidim:release/0.22-stablefrom
coopdevs:fix-erblint
Closed

Fix erblint in Lint Code CI job#6913
sauloperez wants to merge 1 commit intodecidim:release/0.22-stablefrom
coopdevs:fix-erblint

Conversation

@sauloperez
Copy link
Copy Markdown
Contributor

@sauloperez sauloperez commented Nov 23, 2020

🎩 What? Why?

This aims to fix the NameError: uninitialized constant BetterHtml::Parser::HtmlError we are experiencing when running erb-lint in CI by upgrading to erb-lint 0.0.35.

This required relaxing rubocop's version because erb-lint depends on it as welL (See: https://github.com/Shopify/erb-lint/blob/master/erb_lint.gemspec#L27-L33)l. For that, updating deprecated configs in .rubocop.yml was also needed.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

This required relaxing rubocop's version because erblint depends on it
as well. For that, updating deprecated configs in .rubocop.yml was also
needed.
@tramuntanal
Copy link
Copy Markdown
Contributor

Closing as it has been managed in #6939

@sauloperez sauloperez deleted the fix-erblint branch November 27, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants