Fix erblint in CI in 0.23-stable#6939
Merged
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom Nov 26, 2020
Merged
Fix erblint in CI in 0.23-stable#6939tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
Conversation
We suddenly started getting errors like the following in `release/0.22-stable` and `release/0.23-stable`. ``` Run ./.github/run_erblint.sh bundler: failed to load command: erblint (/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.5.0/bin/erblint) NameError: uninitialized constant BetterHtml::Parser::HtmlError Did you mean? HtmlTokenizer ``` Apparently the only way to solve it is upgrading to erblint 0.0.35. That however, requires a Rubocop upgrade that is too costly. This will do the trick since this branch is only meant to receive fixes.
tramuntanal
approved these changes
Nov 26, 2020
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We suddenly started getting errors like the following in
release/0.22-stableandrelease/0.23-stable.Apparently, the only way to solve it is upgrading to erblint 0.0.35. That, however, requires a Rubocop upgrade that is too costly. This will do the trick since this branch is only meant to receive fixes.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
