Skip to content

Add Proposals and Results Content Blocks in Process Groups#6822

Closed
entantoencuanto wants to merge 46 commits intodevelopfrom
feature/process_groups_improvements-proposals_and_results_content_blocks
Closed

Add Proposals and Results Content Blocks in Process Groups#6822
entantoencuanto wants to merge 46 commits intodevelopfrom
feature/process_groups_improvements-proposals_and_results_content_blocks

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Nov 6, 2020

🎩 What? Why?

  • Adds a generic content block to get higfhligted resources associated with components of a participatory space. In this case the space is a participatory process group
  • Defines and registers a content block for highlighted proposals of groups
  • Defines an m-size card for results in decidim-accountability
  • Defines and registers a content block for highlighted results of groups (using m-card)
  • Adds some system tests in participatory process group landing page

Note: This PR is built on top of feature/process_groups_improvements-cta_content_block, the branch of #6821 PR.

📌 Related Issues

Link your PR to an issue

Testing

Enable the 2 content blocks in a group landing page

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto mentioned this pull request Nov 6, 2020
Merged
12 tasks
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-proposals_and_results_content_blocks branch from 3503cae to 35ecb7e Compare November 10, 2020 16:05
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Nov 10, 2020
View reviewed changes
decidim-core/app/assets/stylesheets/decidim/modules/_cards.scss Outdated
border-right: $card-border;
border-right: 0;
border-bottom: $card-border;

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave trailing whitespace

decidim-core/app/assets/stylesheets/decidim/modules/_cards.scss Outdated
border-right: $card-border;
border-right: 0;
border-bottom: $card-border;

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected whitespace at end of line (no-eol-whitespace)

@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-proposals_and_results_content_blocks branch from 35ecb7e to 7173595 Compare November 11, 2020 16:34
@entantoencuanto entantoencuanto marked this pull request as ready for review November 16, 2020 12:37
@andreslucena andreslucena changed the title Feature/process groups improvements proposals and results content blocks Add Proposals and Results Content Blocks in Process Groups Nov 17, 2020
@entantoencuanto
Add migration to add a hashtag column to decidim_participatory_proces…
c75f95c 
…s_groups table
@entantoencuanto
Add factories and admin management from admin of groups hashtag
0e41cbe
@entantoencuanto
Add migration to include metadata columns in decicim_participatory_pr…
7fc382f 
…ocess_groups table
@entantoencuanto
Add factories and admin management from admin of groups metadata
5673fab 
The hashtag attribute has been moved to the metadata section in admin
form
@entantoencuanto
Add validation to group_url participatory process group form attribute
b581c56
@entantoencuanto
Change participatory_process_group homepage to display only content b…
cf14edf 
…locks
@entantoencuanto
Create and register title content block for groups homepage
c39be4b 
This content block contains title, description, number of participatory
processes and hashtag, external url and meta scope if present
@entantoencuanto
Add html content block and remove hero
acb4ddb
@entantoencuanto
Improve meta_scope obtaining in title cell
d92e2b0
@entantoencuanto
Avoid errors if group hashtag is nil
000200c
@entantoencuanto
Get resource in groups title_cell from model scoped_resource_id inste…
975af20 
…ad of controller
@entantoencuanto
Add title content block for groups cell tests
ca2e26e
@entantoencuanto
Add migration to change groups name column and serialized data in ver…
d952497 
…sions
@entantoencuanto
Replace references to name with title in participatory process groups
e433a08
@entantoencuanto
Update participatory process groups system test to check title block
b6efc87
@entantoencuanto
Add metadata content block cell to decidim-participatory_processes
10aabc8
@entantoencuanto
Register metadata content block in participatory process groups landi…
d009375 
…ng page
@entantoencuanto
Add system tests for metadata content block in participatory process …
b225157 
…groups landing page
@entantoencuanto
Remove no longer used proposals view hook for process groups
fd1e5de
@entantoencuanto
Remove no longer used accountability results view hook for process gr…
981e520 
…oups
@entantoencuanto
Remove no longer used meetings view hook for process groups
898b8de
@entantoencuanto
Fix translations issues
f8bfd16
@entantoencuanto
Fix rubocop offenses
ca44ff8
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-proposals_and_results_content_blocks branch 2 times, most recently from d5907e7 to bfd3b25 Compare November 30, 2020 14:44
@entantoencuanto
Add test for cta content block settings admin
685f677
@entantoencuanto
Add order_by_most_recent scope to proposals and results models
25843fc
@entantoencuanto
Add highlighted_proposals content block to decidim-proposals
a9ed4c1 
The content block cell is inherited from a generic content block which
is going to be used with other kind of resources.
@entantoencuanto
Add highlighted_results content block to decidim-accountability
ed21f76
@entantoencuanto
Add highlighted proposals and results content blocks to groups homepage
0d4f7cd
@entantoencuanto
Define m size card for accountability results
6378dd0
@entantoencuanto
Avoid errors on accountability breadcrumb helper
8ff19d7 
When query params are built with the methods provided by the
decidim/tags cell the category is passed within an array and this
generates an exception in the breadcrumb helper
@entantoencuanto
Add cell tests for result cards
01460e5
@entantoencuanto
Use m card to display results in highlighted results content block
8098aa1
@entantoencuanto
Add system tests for proposals and results content blocks in groups l…
b53c178 
…anding page
@entantoencuanto
Remove results count from proposals content block
7d08985
@entantoencuanto
Display participatory space class name in singular in card_m top
4956861
@entantoencuanto
Add module part to ResultsController class in admin
39fca4a
@entantoencuanto
Remove unused method
53b3db2
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-proposals_and_results_content_blocks branch from bfd3b25 to 53b3db2 Compare November 30, 2020 19:10
@entantoencuanto entantoencuanto mentioned this pull request Dec 3, 2020
Closed
12 tasks
@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Dec 4, 2020

Closing, as changes in this PR were already in #6823 which is already merged

@tramuntanal tramuntanal closed this Dec 4, 2020
@tramuntanal tramuntanal deleted the feature/process_groups_improvements-proposals_and_results_content_blocks branch December 4, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@qlty-cloud-legacy qlty-cloud-legacy[bot] qlty-cloud-legacy[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposals and Results content block for Process Groups

3 participants

@entantoencuanto @tramuntanal @Leusev