Fix dependency between surveys and templates#6814
Merged
tramuntanal merged 4 commits intorelease/0.23-stablefrom Nov 6, 2020
Merged
Fix dependency between surveys and templates#6814tramuntanal merged 4 commits intorelease/0.23-stablefrom
tramuntanal merged 4 commits intorelease/0.23-stablefrom
Conversation
Contributor
Author
|
I'm mentioning @mrcasals @josepjaume and @oriolgual in case they have some clue about the explained problem. |
As it should be optional
f6a8fde to
630f947
Compare
microstudi
approved these changes
Nov 6, 2020
ivan-mr
approved these changes
Nov 6, 2020
tramuntanal
added a commit
that referenced
this pull request
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
The dependency between
decidim-surveysanddecidim-templatescreates a strange rubygems dependency problem.In a fresh system when
gem install decidim:0.23.0an error is generated becausedecidim-surveysis not able to resolvedecidim-templates. Bundler on the other side, has no problems resolving the dependencies.In fact we have many similar dependencies between decidim modules that cause no problem, i.e.
decidim-accountabilitydepends upondecidim-commentsand comments is also declared after accountability indecidim.gemspecand there's no problem with that.The key elements of the proposed solution are:
decidim-surveys.gemspecdeclaredecidim-templatesas a develoment_dependencydecidim-templatesdependency indecidim.gemspecThis PR also changes the version of
release/0.23-stableto 0.23.1.rc1.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
