Skip to content

Fix dependency between surveys and templates#6814

Merged
tramuntanal merged 4 commits intorelease/0.23-stablefrom
dep/fix_surveys_templates_rubygems_dep_problem
Nov 6, 2020
Merged

Fix dependency between surveys and templates#6814
tramuntanal merged 4 commits intorelease/0.23-stablefrom
dep/fix_surveys_templates_rubygems_dep_problem

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Nov 6, 2020

🎩 What? Why?

Please describe your pull request.
The dependency between decidim-surveys and decidim-templates creates a strange rubygems dependency problem.
In a fresh system when gem install decidim:0.23.0 an error is generated because decidim-surveys is not able to resolve decidim-templates. Bundler on the other side, has no problems resolving the dependencies.
In fact we have many similar dependencies between decidim modules that cause no problem, i.e. decidim-accountability depends upon decidim-comments and comments is also declared after accountability in decidim.gemspec and there's no problem with that.

The key elements of the proposed solution are:

  • make decidim-surveys.gemspec declare decidim-templates as a develoment_dependency
  • remove decidim-templates dependency in decidim.gemspec

This PR also changes the version of release/0.23-stable to 0.23.1.rc1.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@tramuntanal
Copy link
Copy Markdown
Contributor Author

I'm mentioning @mrcasals @josepjaume and @oriolgual in case they have some clue about the explained problem.

@tramuntanal tramuntanal force-pushed the dep/fix_surveys_templates_rubygems_dep_problem branch from f6a8fde to 630f947 Compare November 6, 2020 09:23
@tramuntanal tramuntanal merged commit a8bed1e into release/0.23-stable Nov 6, 2020
@tramuntanal tramuntanal deleted the dep/fix_surveys_templates_rubygems_dep_problem branch November 6, 2020 11:36
tramuntanal added a commit that referenced this pull request Nov 6, 2020
@tramuntanal tramuntanal mentioned this pull request Nov 6, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants