Skip to content

Improve management of managed user#6748

Merged
tramuntanal merged 24 commits intodevelopfrom
feature/improve-management-of-managed-users
Dec 29, 2020
Merged

Improve management of managed user#6748
tramuntanal merged 24 commits intodevelopfrom
feature/improve-management-of-managed-users

Conversation

@edgarlatorre
Copy link
Copy Markdown
Contributor

@edgarlatorre edgarlatorre commented Oct 26, 2020

🎩 What? Why?

Please describe your pull request.

  • Log action of managing a user
  • Log action of promoting a user

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Admin Log

image

image

♥️ Thank you!

@edgarlatorre edgarlatorre self-assigned this Oct 26, 2020
@edgarlatorre edgarlatorre marked this pull request as draft October 26, 2020 14:13
@edgarlatorre edgarlatorre changed the title Log action when impersonate user Improve management of managed user Oct 26, 2020
@edgarlatorre edgarlatorre linked an issue Oct 27, 2020 that may be closed by this pull request
6 tasks
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch 3 times, most recently from 06fa6ec to af9cb5c Compare October 30, 2020 16:05
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from af9cb5c to c5086f7 Compare November 5, 2020 15:20
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from 819d7bd to c8c1a66 Compare November 9, 2020 08:56
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch 2 times, most recently from e0679f2 to 2e43aaa Compare November 12, 2020 11:16
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from 2e43aaa to ea89df8 Compare November 16, 2020 16:44
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from 58dc27b to 73ad868 Compare December 1, 2020 14:49
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from b8eab39 to 2532fb2 Compare December 1, 2020 18:12
@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from 2532fb2 to 3cbc9ae Compare December 4, 2020 13:36
@andreslucena andreslucena added the project: PAM2020 Barcelona City Council contract label Dec 15, 2020
@mrcasals mrcasals marked this pull request as ready for review December 17, 2020 11:46
@mrcasals
Copy link
Copy Markdown
Contributor

@decidim/core this has been approved by @decidim/product, can you review it please? 😄

@edgarlatorre edgarlatorre force-pushed the feature/improve-management-of-managed-users branch from 55de1ba to 4d58c38 Compare December 26, 2020 10:45
@tramuntanal tramuntanal merged commit 04ce849 into develop Dec 29, 2020
@tramuntanal tramuntanal deleted the feature/improve-management-of-managed-users branch December 29, 2020 07:33
mrcasals added a commit that referenced this pull request May 6, 2021
* Log action when impersonate user

* Create impersonation_log presenter

* Add user to log message

* Log action of promoting user

* Create event for notify verifications error

* Add conflict model to keep track of conflicts

* Improve event to notify verifications conflict

* Notify admins and save conflict when verification fails

* Move conflicts to admin app

* Add transfer_user command

* Remove extra blank line at the end

* use decidim namespace

* Change condition to update email

* Add action log for transfer user

* Change event and error message about conflict

* Add tests for conflicts controller

* update managed user password when transfering user

* Remove confirmation and set user to managed false

* Check confirmed_at is not nil

* Remove validation

* Fix specs

* Change document_number to unique_id

* Change factory to use unique_id instead document_number

* Add test for invalid update

Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements in the management of managed users

4 participants