Skip to content

Fix elections count in Homepage statistics#6684

Merged
tramuntanal merged 1 commit intodevelopfrom
fix/home-statistics-elections_count
Oct 15, 2020
Merged

Fix elections count in Homepage statistics#6684
tramuntanal merged 1 commit intodevelopfrom
fix/home-statistics-elections_count

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

There was a missing i18n statistics home regarding the new Elections module. This PR fixes that.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

  1. Run the db:seeds for the default development_app
  2. Go to the home
  3. See missing i18n error

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Before

imatge

After

imatge

♥️ Thank you!

@tramuntanal tramuntanal self-assigned this Oct 15, 2020
@tramuntanal tramuntanal merged commit bc67fc8 into develop Oct 15, 2020
@tramuntanal tramuntanal deleted the fix/home-statistics-elections_count branch October 15, 2020 09:32
@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: elections type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants