Skip to content

Remove unused /organization_users route#6673

Merged
ivan-mr merged 1 commit intodevelopfrom
fix/unused-organization_users-route
Oct 13, 2020
Merged

Remove unused /organization_users route#6673
ivan-mr merged 1 commit intodevelopfrom
fix/unused-organization_users-route

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

There's an unused route (/organization_users ) to an inexisting controller (users_controller). This PR deletes it.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.
Go to http://localhost:3000/organization_users
It should give you a "No route matches" (404) instead of a "uninitialized constant Decidim::UsersController" (500)
Weirdly I couldn't reproduce this in production (https://meta.decidim.org/organization_users is a 404)

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Before

image

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreslucena !

@ivan-mr ivan-mr merged commit 5a46755 into develop Oct 13, 2020
@ivan-mr ivan-mr deleted the fix/unused-organization_users-route branch October 13, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants