Conversation
|
After adding pg_search and modifying Gemfile.locks and core's gemspec build succeeds. Let's add changes from decidim-core and decidim-dev one after the other. |
4f3237b to
8ef29eb
Compare
|
After adding Searchable into decidim-core and decidim-dev tests are still passing. Going to add search into meetings. |
|
After adding Searchable into decidim-meetings tests are still passing. Going to add search into proposals. |
7da3a1c to
d96d362
Compare
|
Well, I was wrong. There were missing files in the previous push for meetings and now, after adding those files, the problem at decidim-generatos is raising. So we already have constrained the problem to decidim-meetings (probably proposals will have the same problem because both modules implement search the same way, but let's first study the problem in meetings). I'm going to progressively, try:
I guess some of the previous should be the culprit, if not, I'll see. |
|
Discarding decidim-meetings tests for search as culprits. Let's try to comment the |
…keep the inclusion of Decidim::Searchable.
|
Tests were green after modifying Meetings to include Searchable, but failed after adding tests and migrations. I'm suspecting first of the migration. |
|
@tramuntanal in your migrations you need to use a fake class for the models, maybe the error comes from this? 😕 |
|
After refactoring the meetings migration decidim-generators problem has disappeared. Let's keep adding the rest of the code progressively and also refactor the same way the analogue migration in proposals. |
|
Wohooo!!!! |
|
Uooo yeahhh!!! |
|
This PR is now ready to be merged! |
|
@decidim/lot-core This PR is now ready to be merged! |
|
Hi @tramuntanal - nice to see it's finally ready! For traceability purposes, do you think you can change the title and description of the PR so it matches the original one? Future developers might struggle to figure out what happened here ;) |
|
I can remove the "reconstruct incrementally" part of the title because the rest of the title describes best what is the PR about: the search engine MVP. |
|
@decidim/lot-core re-run tests please, a random test failure has appeared. |
|
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
|
Wohoooooo! 🎉 🎊 Nice job @tramuntanal! 😄 |
|
🎉 👏 👏 |
|
yehaaaaa!!! 👏 👏 |
🎩 What? Why?
Implements the search engine MVP as defined in #2589
📌 Related Issues
📋 Subtasks
CHANGELOGentry