Skip to content

Avoid rendering values on the secrets.yml when creating a new app#6653

Merged
Leusev merged 1 commit intodevelopfrom
fix/bulletin_board_app_template
Oct 14, 2020
Merged

Avoid rendering values on the secrets.yml when creating a new app#6653
Leusev merged 1 commit intodevelopfrom
fix/bulletin_board_app_template

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Oct 9, 2020

🎩 What? Why?

The template should mantain the <%= %> block to access the environment variables on the execution of the application.

📌 Related Issues

Testing

  • Create a new dev application using the rake task.
  • Open the secrets.yml file and check that bulletin_board.identification_private_key is not empty.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

♥️ Thank you!

It should access to the code at runtime, and access the environment variables.
@leio10 leio10 added project: e-voting Barcelona City Council contract type: bug labels Oct 9, 2020
@leio10
Copy link
Copy Markdown
Contributor Author

leio10 commented Oct 9, 2020

@decidim/core @slickepinne detected this bug on my PR #6420. Can you review it? Thanks!

Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well catched @leio10
Thanks !! 👍

@Leusev Leusev self-assigned this Oct 14, 2020
@Leusev Leusev merged commit 90ca4fb into develop Oct 14, 2020
@Leusev Leusev deleted the fix/bulletin_board_app_template branch October 14, 2020 07:44
@mrcasals mrcasals added type: fix PRs that implement a fix for a bug and removed type: bug labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: generators project: e-voting Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants