Avoid rendering values on the secrets.yml when creating a new app#6653
Merged
Avoid rendering values on the secrets.yml when creating a new app#6653
Conversation
It should access to the code at runtime, and access the environment variables.
Contributor
Author
|
@decidim/core @slickepinne detected this bug on my PR #6420. Can you review it? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The template should mantain the <%= %> block to access the environment variables on the execution of the application.
📌 Related Issues
Testing
bulletin_board.identification_private_keyis not empty.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots