Add new languages: Korean, Vietnamese and Chinese#6648
Merged
Conversation
Member
Author
|
Also related to #6645 that adds the translation keys for these languages |
Leusev
approved these changes
Oct 14, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Perfect, adding new languages 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
This adds new languages asked by the city of Seattle:
📌 Related Issues
Link your PR to an issue
Related to Add new Crowdin languages #6640
Fixes partially but there are some missing languages:
am Amharic
om Oromo
ti Tigrinya
so Somali
Testing
Describe the best way to test or validate your PR.
Can't be tested yet until we have some keys in the language, although I've followed the docs for adding a new language:
https://docs.decidim.org/en/develop/managing_translations_i18n/#_adding_a_new_language
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.