Skip to content

Add new languages: Korean, Vietnamese and Chinese#6648

Merged
Leusev merged 1 commit intodevelopfrom
feature/new_languages
Oct 14, 2020
Merged

Add new languages: Korean, Vietnamese and Chinese#6648
Leusev merged 1 commit intodevelopfrom
feature/new_languages

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

This adds new languages asked by the city of Seattle:

  • Korean
  • Vietnamese
  • Chinese (Traditional and Simplified)

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Can't be tested yet until we have some keys in the language, although I've followed the docs for adding a new language:
https://docs.decidim.org/en/develop/managing_translations_i18n/#_adding_a_new_language

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@andreslucena andreslucena changed the title Add new languages: Korean, Vietnamese and Chinese (Traditional and Si… Add new languages: Korean, Vietnamese and Chinese Oct 8, 2020
@andreslucena
Copy link
Copy Markdown
Member Author

Also related to #6645 that adds the translation keys for these languages

@Leusev Leusev self-requested a review October 14, 2020 07:33
@Leusev Leusev self-assigned this Oct 14, 2020
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, adding new languages 👍

@Leusev Leusev merged commit 0febba1 into develop Oct 14, 2020
@Leusev Leusev deleted the feature/new_languages branch October 14, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants