Skip to content

Make cors more strict#6642

Merged
tramuntanal merged 1 commit intodecidim:developfrom
codegram:make_cors_more_strict
Oct 8, 2020
Merged

Make cors more strict#6642
tramuntanal merged 1 commit intodecidim:developfrom
codegram:make_cors_more_strict

Conversation

@josepjaume
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Right now, because of the api module, an entire decidim installation will have a very lax CORS policy. This restricts it to the /api resource.

📌 Related Issues

None

Testing

Use a site like https://www.test-cors.org/ to check against an installation with this patch to see it only has CORS enabled on the /api route.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

None

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Oct 8, 2020

@decidim/core can you check this out, please? 😄

@tramuntanal tramuntanal added the graphql-api Affects the GraphQL API label Oct 8, 2020
@tramuntanal tramuntanal merged commit 7fb9c95 into decidim:develop Oct 8, 2020
josepjaume added a commit to i-need-another-coffee/decidim that referenced this pull request Oct 8, 2020
@mrcasals mrcasals deleted the make_cors_more_strict branch October 27, 2020 15:26
@mrcasals mrcasals added module: api type: change PRs that implement a change for an existing feature labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphql-api Affects the GraphQL API module: api type: change PRs that implement a change for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants