Fix "no" Norwegian key for decidim-templates#6609
Merged
tramuntanal merged 4 commits intodevelopfrom Oct 7, 2020
Merged
Conversation
mrcasals
previously approved these changes
Oct 6, 2020
12 tasks
Leusev
approved these changes
Oct 7, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Looks perfect for me @tramuntanal
Furthermore with that i18n spec we'll be aware of new wrong locale key. 👍
Contributor
|
@decidim/core can you fast-track this, please? 😄 |
Contributor
Author
|
yes @mrcasals we're on it, the meetings flaky is resisting us |
Contributor
|
The flaky test is unrelated to this issue, it's a flaky test and you're already working on that in another PR (#6611)... |
Contributor
Author
|
Finally inn! |
12 tasks
roxanaopr
pushed a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Oct 15, 2020
* Fix "no" norwegian key for decidim-templates * Add a test to avoid having this problem again in the future * Add further explanation of the problem * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
Crowdin undid the correction for the Norwegian key in the i18n file at
decidim-templates.This PR fixes the
decidim-templates/config/locales/no.ymlfile and adds a regression test to avoid having this problem again in the future.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
