Merged
Conversation
Until now these two pages were DEFAULT_PAGES, meaning that they were created by default and it didn't allow admins to delete them. This was a mistake and we should allow deleting these pages.
mrcasals
reviewed
Oct 5, 2020
| success: Great! You have accepted the terms and conditions. | ||
| form: | ||
| agreement: I agree this terms | ||
| agreement: I agree with these terms |
Contributor
There was a problem hiding this comment.
OMG this has been bugging me for a while but I never spent time to open a PR, thanks!!
Contributor
There was a problem hiding this comment.
The admin terms button is still not fixed though, I opened an issue. 😁
tramuntanal
approved these changes
Oct 6, 2020
12 tasks
roxanaopr
pushed a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Oct 15, 2020
* Allow deleting 'accessibility' and 'faq' pages Until now these two pages were DEFAULT_PAGES, meaning that they were created by default and it didn't allow admins to delete them. This was a mistake and we should allow deleting these pages. * Fix grammar in ToS acceptance * Fix failing tests Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
Making some docs I found out that we're marking two static pages as non-deletable. I've talked with @carolromero and we agreed that this shouldn't be like that.
This PR allows the deletion of these default pages.
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
Before
After
(already existing db)
(new db)
