Require the necessary "zip" gem in the open data exporter#6464
Merged
tramuntanal merged 1 commit intodecidim:developfrom Nov 3, 2020
Merged
Require the necessary "zip" gem in the open data exporter#6464tramuntanal merged 1 commit intodecidim:developfrom
tramuntanal merged 1 commit intodecidim:developfrom
Conversation
Without this, the exporter would not work in environments where the "zip" gem is not explicitly loaded through the Gemfile, as in most Decidim instances.
carlobeltrame
added a commit
to puzzle/decidim-zuerich
that referenced
this pull request
Sep 9, 2020
This will be obsolete once we use a release of decidim that includes this PR: decidim/decidim#6464
carlobeltrame
added a commit
to puzzle/decidim-zuerich
that referenced
this pull request
Sep 9, 2020
This will be obsolete once we use a release of decidim that includes this PR: decidim/decidim#6464
3 tasks
carlobeltrame
added a commit
to puzzle/decidim-zuerich
that referenced
this pull request
Sep 9, 2020
This will be obsolete once we use a release of decidim that includes this PR: decidim/decidim#6464
Contributor
|
In my experiments, when I add the zip gem to a decidim project (using It seems Any idea how to work around this issue until this PR is merged and released? |
Contributor
Author
|
@carlobeltrame You can just override the file locally in your instance by creating the same service file in your application. To patch, run this at the root of your project: cd /path/to/your/project
mkdir -p app/services/decidim && wget -O app/services/decidim/open_data_exporter.rb https://raw.githubusercontent.com/decidim/decidim/474c845d313a86e290b36b1b1b8382d1fdccc306/decidim-core/app/services/decidim/open_data_exporter.rbRemember to remove it with the next version after this will be merged to core! |
Contributor
Author
|
Is there something blocking this getting merged? This applies the same fix to the open data exported what is already applied in the core in multiple locations: |
tramuntanal
approved these changes
Nov 3, 2020
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Nov 3, 2020
Without this, the exporter would not work in environments where the "zip" gem is not explicitly loaded through the Gemfile, as in most Decidim instances.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Without this, the exporter would not work in environments where the "zip" gem is not explicitly loaded through the Gemfile, as in most Decidim instances.
Why I think it works with the rspec tests is that it loads all the Decidim's dependency gems through the dummy app's Gemfile (which is the Gemfile at the root of this project). However, this is not the case in many production environments.