Add migration to update Proposal endorsement Notifications#6367
Merged
tramuntanal merged 1 commit intodevelopfrom Jul 30, 2020
Merged
Conversation
288a6da to
40178ba
Compare
Leusev
approved these changes
Jul 30, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Looks good for me @tramuntanal 👍
ivan-mr
approved these changes
Jul 30, 2020
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Due to #5542 notifications related with proposal endorsements are generated by a different event than it were before.
Now endorsements are generalized, to be applied to different resources, and so are the corresponding events and notifications. This meant removing the old
decidim.events.proposals.proposal_endorsedevent and introducing a newdecidim.events.resource_endorsedevent. This changes implied also removing the translations for the old event, letting already created notifications with translation missing when being rendered.This PR solves this situation by updating all
Decidim::Notificationcorresponding to Proposal endorsement to the new event_name and event_class.📌 Related Issues