Add questions and answers to elections#6129
Merged
microstudi merged 14 commits intodevelopfrom May 28, 2020
Merged
Conversation
8f7336b to
4e123fb
Compare
4e123fb to
f294091
Compare
slickepinne
previously approved these changes
May 27, 2020
gchacart
reviewed
May 27, 2020
| # from the admin panel. | ||
| class DestroyAnswer < Rectify::Command | ||
| include ::Decidim::AttachmentMethods | ||
| include ::Decidim::GalleryMethods |
Contributor
There was a problem hiding this comment.
I'm just curious about what happens when you delete an answer that has images, images get also deleted? Where are they stored?
Contributor
Author
gchacart
previously approved these changes
May 27, 2020
Contributor
gchacart
left a comment
There was a problem hiding this comment.
Excellent job!!
I got a rough idea of the architecture just because there are so many new things for me here, but the specific commits helped a lot for understanding!!!
🚀
Contributor
Author
|
@decidim/core this PR was approved by Product, so it's ready to be reviewed! |
microstudi
previously approved these changes
May 28, 2020
Contributor
microstudi
left a comment
There was a problem hiding this comment.
Excellent job @leio10. Pleased to see that the API is being taking into account!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds questions and answers to the elections module and implements the admin zone for those models.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)