change filter locales strings from initiatives to proposals#6013
change filter locales strings from initiatives to proposals#6013tramuntanal merged 3 commits intodevelopfrom
Conversation
tramuntanal
left a comment
There was a problem hiding this comment.
just one question @microstudi
| created: Created | ||
| discarded: Discarded | ||
| published: Published | ||
| rejected: Rejected |
There was a problem hiding this comment.
If this strings have been reused, doesn't it mean that they were already being used before? If we remove them won't it affect the initiatives module?
There was a problem hiding this comment.
the initiatives modules will take the string from the proposals module, this string is moved there.
The problem now is that the proposals module is using this string and, if initiatives is not active, doesn't find it.
If we keep it here, it will be repeated in 2 files isn't?
There was a problem hiding this comment.
I get the problem. But I'm referring to the remote (but possible?) case where initiatives are enabled and proposals not. Also, to have the code correctly grouped, each module should be as independent as possible, and it seems to me that this should not be a reason to have this dependency.
There was a problem hiding this comment.
In fact I agree with you. The thing is that is that many strings are created this way, this means that we will should "namespace" all strings in all modules. That's not a quick fix. We should create a issue for that and treat it properly.
I any case, I don't thing it is possible to run decidim without the proposals module.
There was a problem hiding this comment.
I any case, I don't thing it is possible to run decidim without the proposals module.
Yes, that's the case right now, it's one of the (too many) modules that we've as a dependency by default. The thing is that shouldn't be, as we're starting to see some instances that have only Initiatives module enabled.
But I also agree on having this discussion on another place, and that for the moment this PR is OK (proposals can be an implicit depedency of initatives; there are cases where initiatives are not enabled)
…6013) * position locales in correct modules * add changelog Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
🎩 What? Why?
With the introduction of filters for proposals in the admin, some strings that were in the initiatives module were reused. However, as initiatives is not enable by default when installing Decidim the system cannot find those strings and result in weird menus in production and a total failure when developing.
We should move the reused strings to proposals as this module is always enabled.
NOTE: this should be backported to 0.20 and 0.21
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Without initiatives enabled this is how it looks the filter in the proposals admin (in development mode just fails):
