Skip to content

Collapse and expand questions when editing questionnaire#5945

Closed
verarojman wants to merge 22 commits intodecidim:developfrom
Platoniq:feature/collapse-questions
Closed

Collapse and expand questions when editing questionnaire#5945
verarojman wants to merge 22 commits intodecidim:developfrom
Platoniq:feature/collapse-questions

Conversation

@verarojman
Copy link
Copy Markdown
Contributor

@verarojman verarojman commented Apr 9, 2020

Note: This is a new version of #5933 to get rid of some unwanted commits.

🎩 What? Why?

This PR allows for questions to be collapsed into their statement in order for the experience of editing a questionnaire to be more comfortable when there is a considerable number of questions being edited. They can later be expanded, and collapsed/expanded all at once with two buttons at the beginning of the questions list.

As part of this feature, the question title in the collapsed version is updated with the question statement input (instead of e.g. "Question 3") to have a better visual reference of the questions when they are all collapsed.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots

Example-Optimized

Copy link
Copy Markdown
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verarojman the file decidim/forms/admin/collapsible_questions.js should be included in the sprockets manifest: decidim-forms/app/assets/config/decidim_forms_manifest.js
Otherwise it is not found in production sites (error 500).

@microstudi
Copy link
Copy Markdown
Contributor

Thanks @verarojman a question: This PR fixes #5947 ?
also, if you can solve the changelog would be great!

@microstudi
Copy link
Copy Markdown
Contributor

@carolromero does @decidim/product approves this? there's a meta-decidim link in the production. Thanks!

@carolromero
Copy link
Copy Markdown
Member

@microstudi yes, this is approved by @decidim/product. This is a very valuable contribution, thanks @verarojman!

@verarojman
Copy link
Copy Markdown
Contributor Author

verarojman commented Apr 24, 2020

Thanks @verarojman a question: This PR fixes #5947 ?
also, if you can solve the changelog would be great!

#5947 fixes that on its own (this PR does not). I made a separate PR so it's easy to integrate.

Edit: I just updated the changelog

@microstudi
Copy link
Copy Markdown
Contributor

Thanks a lot @verarojman !

Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @verarojman !!
It LGTM but there are a couple of issues that must be addressed please

@tramuntanal tramuntanal self-assigned this May 11, 2020
@ivan-mr
Copy link
Copy Markdown
Contributor

ivan-mr commented May 11, 2020

Please @verarojman can you fix conflicts? thanks

@tramuntanal
Copy link
Copy Markdown
Contributor

Superseded by #6099. Thanks @verarojman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants