[CI] Allow postgres Docker image without password#5741
Merged
tramuntanal merged 1 commit intomasterfrom Feb 17, 2020
Merged
Conversation
Contributor
Author
|
Hi @decidim/core! This PR prevents builds from running, can you prioritize the review of this PR please? Thanks! |
agustibr
approved these changes
Feb 17, 2020
8 tasks
tramuntanal
approved these changes
Feb 17, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @mrcasals ,
This is a great proactive PR but we were already working on it and communicated the situation in Gitter and Telegram. It would have been great to coordinate before doing the PR to avoid duplicate work.
5 tasks
Contributor
Author
|
@tramuntanal oh, I didn't see any issue or PR working on it, so I went ahead and sent one, sorry about the miscoordination! I'm not on Decidim's Telegram channel (I was not aware there's one) and I don't use Gitter, so I just missed these notifications... I'll ask first on future events! |
microstudi
pushed a commit
to Platoniq/decidim
that referenced
this pull request
Feb 21, 2020
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In CircleCI we always use the latest PostgreSQL Docker image. This weekend a new version was released, and it added a breaking change that prevented the image from starting.
This PR fixes the breaking change.
Info:
📌 Related Issues
None specifically, but as an example see this build from master failing due to this error:
https://circleci.com/workflow-run/f6618da8-ce9c-4509-b006-0f6eaaf81a4a
📋 Subtasks
None