Skip to content

Statistics module in Process home#5694

Closed
htmlboy wants to merge 2 commits intomasterfrom
feature/pam2020/activity-section
Closed

Statistics module in Process home#5694
htmlboy wants to merge 2 commits intomasterfrom
feature/pam2020/activity-section

Conversation

@htmlboy
Copy link
Copy Markdown
Contributor

@htmlboy htmlboy commented Feb 10, 2020

🎩 What? Why?

Redesigned highlighted statistics module in home.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Screenshot 2020-02-10 at 18 22 05

@htmlboy htmlboy added the project: PAM2020 Barcelona City Council contract label Feb 10, 2020
@htmlboy htmlboy requested review from carolromero, eva-sl and tramuntanal and removed request for tramuntanal February 10, 2020 10:59
@carolromero
Copy link
Copy Markdown
Member

Hi @htmlboy, good job! Nothing to do with the initial mockup, thankfully 😂

Just one thing: I just did a test to see how it works in context and maybe it would work better to line it up on the left like the other elements? What do you think?

imatge

@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Feb 10, 2020

@carolromero (edited) I'll take a look!

@carolromero
Copy link
Copy Markdown
Member

@htmlboy oops nope, this issue specifically refers to changes in the homepage of a Participary Process 😬
Here in #5635:

As an admin I want to better configure if Metrics get shown on a given Participatory Process, and as an user I want to see more data on Activity. Also the terminology is not the same on backend and frontend and it's frustrating.

@agustibr agustibr changed the title Statistics module in home Statistics module in Process home Feb 10, 2020
@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Feb 10, 2020

@carolromero I've changed the demo and screenshot to the process page and added some fixes. Anyway, I wouldn't left align the text inside the stats blocks (we should remove the separators then, in order to keep alignment balanced, and the whole structure will lose some appeal). Thoughts?

@carolromero
Copy link
Copy Markdown
Member

@htmlboy I think now it's well balanced, we go with your updated design! Thanks

@agustibr
Copy link
Copy Markdown
Contributor

agustibr commented Feb 11, 2020

@htmlboy this branch was merged into #5688 😄
shall I close this PR?

@mrcasals
Copy link
Copy Markdown
Contributor

@agustibr yes, let's close it then! 😄

@mrcasals mrcasals closed this Feb 11, 2020
@tramuntanal tramuntanal deleted the feature/pam2020/activity-section branch June 25, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: PAM2020 Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants