Link author meetings when creating a proposal#5674
Merged
tramuntanal merged 5 commits intomasterfrom Feb 9, 2020
Merged
Conversation
d039016 to
273bb90
Compare
Contributor
Author
|
I had to rebase to get the changes from #5673, but @decidim/core this has been approved by Product, can you review it please? 😄 |
5 tasks
leio10
approved these changes
Feb 6, 2020
tramuntanal
approved these changes
Feb 9, 2020
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When creating a proposal from the admin section, admins can mark it as coming from a meeting. When this is checked and a meeting is selected, the proposal is created with that meeting as author, but this doesn't use the "linked resources" feature. This link can only be created from the meeting page, when closing it. This forces admins to duplicate their work.
This PR improves the proposal creation process so that when a meeting is set as an author of a proposal, the proposal and the meeting are automatically linked.
Screenshots for this PR might not be very relevant, since nothing has changed in the layout. This PR simplifies a two-step process so that it can be done in a single step.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
This is how a proposal looks when it has a linked meeting:
This is a meeting with two proposals automatically linked, setting this meeting as author:
